Github user DazhuangSu commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r132893104
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,55 @@ case class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15704
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87914133
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -243,7 +243,7 @@ partitionSpec
;
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87910722
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,58 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87910682
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -215,8 +215,14 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87892226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -215,8 +215,14 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87895663
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,58 @@ case class AlterTableRenamePartitionCommand(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87896496
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,108 @@ class HiveDDLSuite
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87895874
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,58 @@ case class AlterTableRenamePartitionCommand(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87896147
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -243,7 +243,7 @@ partitionSpec
;
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87688739
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,66 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87688495
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,66 @@ case class AlterTableRenamePartitionCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87684919
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,111 @@ class HiveDDLSuite
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87683697
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,111 @@ class HiveDDLSuite
}
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87683492
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,66 @@ case class AlterTableRenamePartitionCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87559593
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87558776
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87556548
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87555750
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87555430
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87554964
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87554053
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87549789
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,102 @@ class HiveDDLSuite
}
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87549043
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -226,6 +227,63 @@ class HiveDDLSuite
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87546041
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -226,6 +227,63 @@ class HiveDDLSuite
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86393914
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -243,7 +243,7 @@ partitionSpec
;
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86389182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86386317
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86385850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,41 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86385701
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86385537
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -243,7 +243,7 @@ partitionSpec
;
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86377116
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86378445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86376440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,41 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86374321
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -243,7 +243,7 @@ partitionSpec
;
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86296370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,40 @@ class AstBuilder extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86296115
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86295656
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86292070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,40 @@ class AstBuilder extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86291888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -193,6 +193,9 @@ class AstBuilder extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86291769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,40 @@ class AstBuilder extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86291653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,40 @@ class AstBuilder extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86291176
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86291122
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -29,9 +29,10 @@ import
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86291115
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86291078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86290924
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86290826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,40 @@ class AstBuilder extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86290671
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -29,9 +29,10 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86289128
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,56 @@ case class AlterTableRenamePartitionCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86288958
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -226,6 +227,79 @@ class HiveDDLSuite
}
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86288781
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,40 @@ class AstBuilder extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86282010
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -226,6 +227,63 @@ class HiveDDLSuite
}
}
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86242187
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -193,6 +193,9 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86239543
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,53 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86237888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,38 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86238278
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,53 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86076296
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -226,6 +227,63 @@ class HiveDDLSuite
}
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86075964
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,53 @@ case class AlterTableRenamePartitionCommand(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86075872
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,53 @@ case class AlterTableRenamePartitionCommand(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86075107
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,53 @@ case class AlterTableRenamePartitionCommand(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86074588
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -204,6 +207,38 @@ class AstBuilder extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r86015221
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,53 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r85984522
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -631,6 +631,42 @@ private[spark] class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r85963632
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -631,6 +631,42 @@ private[spark] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r85873381
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -631,6 +631,42 @@ private[spark] class HiveExternalCatalog(conf:
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/15704
[SPARK-17732][SQL] ALTER TABLE DROP PARTITION should support comparators
## What changes were proposed in this pull request?
This PR aims to support `comparators`, e.g. '<', '<=',
67 matches
Mail list logo
