[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89267570 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89265835 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -310,6 +270,110 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89264465 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -310,6 +270,110 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258891 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,176 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258401 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258367 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258326 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258177 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258106 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258088 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -319,7 +319,8 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89258070 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89257869 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89257721 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89257647 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,170 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89180234 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,164 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89113173 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,164 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89061315 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89061001 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89053783 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala --- @@ -100,99 +100,30 @@ object

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89048248 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89034281 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89039895 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89030028 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89033107 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89034659 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala --- @@ -100,99 +100,30 @@ object

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89038988 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89035720 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89039488 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r89025123 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88999562 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88999529 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88995033 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88994866 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88994769 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88954353 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88958613 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88906125 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88905820 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88905360 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics(

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88891559 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -58,60 +61,127 @@ case class Statistics( }

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88857244 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -627,26 +629,43 @@ private[spark] class

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88843463 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -627,26 +629,43 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15959#discussion_r88843445 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala --- @@ -100,99 +100,30 @@ object AnalyzeColumnCommand

[GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...

2016-11-20 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/15959 [SPARK-18522][SQL] Explicit contract for column stats serialization ## What changes were proposed in this pull request? The current implementation of column stats uses the base64 encoding of the