Github user hhbyyh closed the pull request at:
https://github.com/apache/spark/pull/16020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16020#discussion_r90599078
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -334,10 +334,10 @@ class KMeans @Since("1.5.0") (
val summary =
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16020#discussion_r89780207
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -255,10 +256,19 @@ class BisectingKMeans @Since("2.0.0") (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16020#discussion_r89740159
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -273,6 +283,7 @@ class BisectingKMeans @Since("2.0.0") (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16020#discussion_r89740085
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -334,10 +334,8 @@ class KMeans @Since("1.5.0") (
val summary = new
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16020#discussion_r89740051
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -255,10 +256,19 @@ class BisectingKMeans @Since("2.0.0") (
GitHub user hhbyyh opened a pull request:
https://github.com/apache/spark/pull/16020
[SPARK-18596][ML] add checking and caching to bisecting kmeans
## What changes were proposed in this pull request?
jira: https://issues.apache.org/jira/browse/SPARK-18596
This is a follow
