Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r159016507
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -133,7 +134,10 @@ class CrossValidator @Since("1.2.0")
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r138133273
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -85,6 +86,32 @@ private[ml] trait ValidatorParams extends HasSeed
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r138133238
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -85,6 +86,32 @@ private[ml] trait ValidatorParams extends HasSeed
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r137546848
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -85,6 +86,32 @@ private[ml] trait ValidatorParams extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r137545402
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -85,6 +86,32 @@ private[ml] trait ValidatorParams extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r137542479
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala ---
@@ -85,6 +86,32 @@ private[ml] trait ValidatorParams extends
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131454343
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -133,7 +134,10 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131340257
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -133,7 +134,10 @@ class CrossValidator @Since("1.2.0")
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131270741
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -133,7 +134,10 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131133998
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -66,6 +66,29 @@ class CrossValidatorSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131133851
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TuningSummary.scala ---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131133018
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -133,7 +134,10 @@ class CrossValidator @Since("1.2.0")
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131132815
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -229,6 +233,29 @@ class CrossValidatorModel private[ml] (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131132649
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -231,6 +235,29 @@ class TrainValidationSplitModel private[ml] (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r131133463
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TuningSummary.scala ---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r125782939
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -226,6 +230,29 @@ class TrainValidationSplitModel private[ml] (
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r91957172
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -123,7 +124,10 @@ class TrainValidationSplit @Since("1.5.0")
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/16158#discussion_r90970832
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -226,6 +230,29 @@ class TrainValidationSplitModel private[ml] (
GitHub user hhbyyh opened a pull request:
https://github.com/apache/spark/pull/16158
[SPARK-18724][ML] Add TuningSummary for TrainValidationSplit
## What changes were proposed in this pull request?
jira: https://issues.apache.org/jira/browse/SPARK-18724
Currently
19 matches
Mail list logo