[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-12 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r92059870 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -119,7 +119,8 @@ abstract class ExternalCatalog {

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r92058687 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -119,7 +119,8 @@ abstract class ExternalCatalog {

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91853357 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -190,87 +258,39 @@ class HiveCommandSuite extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91852909 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -168,14 +200,50 @@ class HiveCommandSuite extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-10 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91846277 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -190,87 +258,39 @@ class HiveCommandSuite extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-10 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91840677 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -418,4 +431,19 @@ class HiveCommandSuite extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91829517 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -418,4 +431,19 @@ class HiveCommandSuite extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91829413 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -418,4 +431,19 @@ class HiveCommandSuite extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91829355 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -418,4 +431,19 @@ class HiveCommandSuite extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91805220 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -325,7 +326,8 @@ case class InsertIntoHiveTable(

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91621845 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala --- @@ -325,7 +326,8 @@ case class InsertIntoHiveTable(

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r9161 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -749,12 +755,6 @@ private[client] class Shim_v0_14 extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91567019 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -749,12 +755,6 @@ private[client] class Shim_v0_14 extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16179#discussion_r91540704 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -749,12 +755,6 @@ private[client] class Shim_v0_14 extends

[GitHub] spark pull request #16179: [SPARK-18752][hive] "isSrcLocal" value should be ...

2016-12-06 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/16179 [SPARK-18752][hive] "isSrcLocal" value should be set from user query. The value of the "isSrcLocal" parameter passed to Hive's loadTable and loadPartition methods needs to be set according to