[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107822881 --- Diff: docs/sql-programming-guide.md --- @@ -1223,6 +1223,13 @@ the following case-insensitive options: This is a JDBC writer related option. If

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107728981 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -680,19 +681,71 @@ object JdbcUtils

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107729028 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala --- @@ -362,4 +363,147 @@ class JDBCWriteSuite extends

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107728867 --- Diff: docs/sql-programming-guide.md --- @@ -1223,6 +1223,13 @@ the following case-insensitive options: This is a JDBC writer related

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107611698 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala --- @@ -362,4 +363,147 @@ class JDBCWriteSuite extends SharedSQLContext

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107607034 --- Diff: docs/sql-programming-guide.md --- @@ -1223,6 +1223,13 @@ the following case-insensitive options: This is a JDBC writer related option. If

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107606880 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -680,19 +681,71 @@ object JdbcUtils extends

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-22 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107562733 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -680,19 +681,63 @@ object JdbcUtils

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-22 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107562849 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala --- @@ -362,4 +363,80 @@ class JDBCWriteSuite extends

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-22 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107562605 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -680,19 +681,63 @@ object JdbcUtils

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107091965 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala --- @@ -362,4 +363,80 @@ class JDBCWriteSuite extends SharedSQLContext with

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107086057 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala --- @@ -362,4 +363,80 @@ class JDBCWriteSuite extends SharedSQLContext

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107084604 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -680,19 +681,63 @@ object JdbcUtils extends

[GitHub] spark pull request #16209: [SPARK-10849][SQL] Adds option to the JDBC data s...

2017-03-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16209#discussion_r107084419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -680,19 +681,63 @@ object JdbcUtils extends