[GitHub] spark pull request #16296: [SPARK-18885][SQL][WIP] unify CREATE TABLE syntax...

2016-12-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16296#discussion_r93011311 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -69,16 +69,19 @@ statement | ALTER DATABASE

[GitHub] spark pull request #16296: [SPARK-18885][SQL][WIP] unify CREATE TABLE syntax...

2016-12-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16296#discussion_r92655270 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -69,16 +69,19 @@ statement | ALTER DATABASE

[GitHub] spark pull request #16296: [SPARK-18885][SQL][WIP] unify CREATE TABLE syntax...

2016-12-15 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/16296 [SPARK-18885][SQL][WIP] unify CREATE TABLE syntax for data source and hive serde tables ## What changes were proposed in this pull request? Today we have different syntax to create data