[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2017-01-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r94288555 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala --- @@ -124,6 +137,33 @@ class WatermarkSuite extends StreamT

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2017-01-01 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r94288180 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala --- @@ -124,6 +137,33 @@ class WatermarkSuite extends StreamT

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2017-01-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r94287885 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala --- @@ -124,6 +137,33 @@ class WatermarkSuite extends Stre

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-20 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r93364798 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -387,7 +387,7 @@ class StreamExecution( la

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-20 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r93357063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -387,7 +387,7 @@ class StreamExecution(

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r93355210 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -387,7 +387,7 @@ class StreamExecution(

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-20 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r93353338 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -387,7 +387,7 @@ class StreamExecution( la

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-20 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r93349575 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -387,7 +387,7 @@ class StreamExecution(

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r92904102 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala --- @@ -124,6 +137,29 @@ class WatermarkSuite extends Stream

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-16 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r92903733 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala --- @@ -124,6 +137,29 @@ class WatermarkSuite extends StreamTest

[GitHub] spark pull request #16304: [SPARK-18894][SS] Fix event time watermark delay ...

2016-12-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/16304#discussion_r92902755 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/EventTimeWatermarkSuite.scala --- @@ -124,6 +137,29 @@ class WatermarkSuite extends Stream