[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16564 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-16 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16564#discussion_r9636 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -898,11 +899,15 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16564#discussion_r96108323 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -898,11 +899,15 @@ class DatasetSuite extends QueryTest with SharedSQLCon

[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-13 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16564#discussion_r96053927 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -898,11 +899,15 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16564#discussion_r95979368 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -898,11 +899,15 @@ class DatasetSuite extends QueryTest with SharedSQLCon

[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16564#discussion_r95942753 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -898,11 +899,15 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16564#discussion_r95942576 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -898,11 +899,15 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request #16564: [SPARK-19065][SQL]Don't inherit expression id in ...

2017-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16564#discussion_r95938778 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -898,11 +899,15 @@ class DatasetSuite extends QueryTest with SharedSQLCon