[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100859963 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-13 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100771130 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100723941 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -500,6 +527,23 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100723919 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100713312 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -500,6 +527,23 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100713251 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -477,6 +483,27 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100712695 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -98,6 +98,7 @@ object DateTimeUtils { def new

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100687862 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,10 @@ object DateTimeUtils { sdf

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100687520 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,10 @@ object DateTimeUtils { sdf

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-11 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100683849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,10 @@ object DateTimeUtils { sdf

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100680992 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,10 @@ object DateTimeUtils { sdf

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-10 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100656533 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -465,15 +465,15 @@ case class DateFormat

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100539828 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -465,15 +465,15 @@ case class DateForma

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-10 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100539384 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -477,6 +475,24 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-10 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100539442 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,12 @@ object DateTimeUtils { sdf

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100523109 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,12 @@ object DateTimeUtils { sdf

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100523512 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -477,6 +475,24 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100524361 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala --- @@ -500,6 +516,20 @@ class DateFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-09 Thread windpiger
GitHub user windpiger opened a pull request: https://github.com/apache/spark/pull/16870 [SPARK-19496][SQL]to_date udf to return null when input date is invalid ## What changes were proposed in this pull request? Currently the udf `to_date` has different return value with an