Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102579830
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102572126
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102394580
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102394378
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102391414
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102381390
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102380326
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102379272
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102378877
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102378594
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -129,6 +156,33 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102378522
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -129,6 +156,33 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102378336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1143,6 +1144,24 @@ object ReplaceDistinctWithAggregate
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102378293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -869,3 +869,12 @@ case object
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102290771
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101878586
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -240,6 +241,9 @@ abstract class SparkStrategies extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101878435
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -129,6 +156,18 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101878213
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -98,6 +104,27 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101878041
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101878019
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101878004
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101877959
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101877982
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101877518
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala ---
@@ -338,7 +338,7 @@ class StreamSuite extends StreamTest {
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101877274
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101872099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101871892
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101871744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101871632
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101871507
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101871078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101870839
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -68,6 +67,37 @@ trait StateStoreWriter extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101870824
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -68,6 +67,37 @@ trait StateStoreWriter extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101870674
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -249,6 +253,17 @@ abstract class SparkStrategies extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101870219
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -869,3 +869,11 @@ case object
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101867628
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala ---
@@ -338,7 +338,7 @@ class StreamSuite extends StreamTest {
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101866240
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2006,15 +2006,19 @@ class Dataset[T] private[sql](
}
cols
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101862301
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2006,15 +2006,19 @@ class Dataset[T] private[sql](
}
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101858190
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2006,15 +2006,19 @@ class Dataset[T] private[sql](
}
cols
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101834289
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -35,6 +35,9 @@ object
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101825645
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -112,6 +128,12 @@ object
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101824321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -35,6 +35,9 @@ object
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101825992
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -869,3 +869,11 @@ case object
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101824789
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -60,6 +68,14 @@ object
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101827697
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/DeduplicationSuite.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101822290
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -321,3 +327,66 @@ case class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r101821462
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
---
@@ -98,6 +104,27 @@ class
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/16970
[SPARK-19497][SS]Implement streaming deduplication
## What changes were proposed in this pull request?
This PR adds a special streaming deduplication operator to support
`dropDuplicates`
48 matches
Mail list logo
