[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101971506 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -482,6 +482,15 @@ case class JsonTuple(children

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101968164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -482,6 +482,15 @@ case class JsonTuple(chi

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101950039 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -482,6 +482,15 @@ case class JsonTuple(children

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101950073 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala --- @@ -174,4 +174,44 @@ class JsonFunctionsSuite extends QueryTest with Sha

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101948866 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -482,6 +482,15 @@ case class JsonTuple(chil

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101948552 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala --- @@ -174,4 +174,44 @@ class JsonFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101948378 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala --- @@ -174,4 +174,44 @@ class JsonFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101948229 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,24 @@ object JacksonUtils { sche

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101947987 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -482,6 +482,15 @@ case class JsonTuple(chil

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101947601 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,24 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101947505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -482,6 +482,15 @@ case class JsonTuple(chil

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101947175 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,26 @@ object JacksonUtils { sche

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101947094 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,26 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101946265 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,26 @@ object JacksonUtils { sche

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101909627 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,26 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101909598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,26 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101909847 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +60,26 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101909916 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -482,6 +482,15 @@ case class JsonTuple(chi

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101891758 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -18,7 +18,14 @@ package org.apache.spark.sql.ca

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101891914 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala --- @@ -174,4 +174,44 @@ class JsonFunctionsSuite extends QueryTest with

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16981#discussion_r101891903 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonUtils.scala --- @@ -55,4 +62,32 @@ object JacksonUtils {

[GitHub] spark pull request #16981: [SPARK-19637][SQL] Add from_json/to_json in Funct...

2017-02-17 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/16981 [SPARK-19637][SQL] Add from_json/to_json in FunctionRegistry ## What changes were proposed in this pull request? This pr added entries in `FunctionRegistry` and supported `from_json`/`to_json`