Github user maropu closed the pull request at:
https://github.com/apache/spark/pull/17164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17164#discussion_r105407263
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregateCodegenHelper.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17164#discussion_r105404213
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala
---
@@ -106,6 +105,126 @@ case class SortAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17164#discussion_r105404064
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregateCodegenHelper.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17164#discussion_r105403987
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala
---
@@ -106,6 +105,126 @@ case class SortAggregateExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17164#discussion_r105403332
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregateCodegenHelper.scala
---
@@ -0,0 +1,226 @@
+/*
+ * Licensed to
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/17164
[SPARK-16844][SQL] Support codegen for sort-based aggreagate
## What changes were proposed in this pull request?
This is the rework of #14481.
## How was this patch tested?
Checked
