[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-08 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r132021227 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala --- @@ -107,9 +103,9 @@ class

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-08 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r131992917 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala --- @@ -83,6 +83,36 @@ class

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-07 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r131824713 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala --- @@ -82,6 +83,23 @@ class

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-07 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r131790673 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -463,7 +479,7 @@ private[ml] class FeedForwardModel private( private

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130746928 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -463,7 +479,7 @@ private[ml] class FeedForwardModel private( private var

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130747030 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -363,7 +363,7 @@ private[ann] trait TopologyModel extends Serializable { *

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130746665 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -463,7 +479,7 @@ private[ml] class FeedForwardModel private( private var

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-08-01 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r130747996 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala --- @@ -82,6 +83,23 @@ class

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-07-26 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r129697649 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -463,7 +479,7 @@ private[ml] class FeedForwardModel private( private

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-07-26 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r129697890 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -527,9 +544,21 @@ private[ml] class FeedForwardModel private(

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-07-26 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17373#discussion_r129698281 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -527,9 +544,21 @@ private[ml] class FeedForwardModel private(

[GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model

2017-03-21 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/17373 [SPARK-12664] Expose probability in mlp model ## What changes were proposed in this pull request? Modify MLP model to inherit `ProbabilisticClassificationModel` and so that it can