[GitHub] spark pull request #17432: [SPARK-20086][SQL] CollapseWindow should not coll...

2017-03-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17432#discussion_r108086367 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -597,12 +597,14 @@ object CollapseRepartition exten

[GitHub] spark pull request #17432: [SPARK-20086][SQL] CollapseWindow should not coll...

2017-03-26 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17432#discussion_r108074254 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -597,12 +597,14 @@ object CollapseRepartition exten

[GitHub] spark pull request #17432: [SPARK-20086][SQL] CollapseWindow should not coll...

2017-03-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17432#discussion_r108072266 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -597,12 +597,14 @@ object CollapseRepartition exten

[GitHub] spark pull request #17432: [SPARK-20086][SQL] CollapseWindow should not coll...

2017-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17432: [SPARK-20086][SQL] CollapseWindow should not coll...

2017-03-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17432#discussion_r108065494 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -597,12 +597,14 @@ object CollapseRepartition ex

[GitHub] spark pull request #17432: [SPARK-20086][SQL] CollapseWindow should not coll...

2017-03-26 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/17432 [SPARK-20086][SQL] CollapseWindow should not collapse dependent adjacent windows ## What changes were proposed in this pull request? The `CollapseWindow` is currently to aggressive when coll