[GitHub] spark pull request #17532: [SPARK-20214][ML] Make sure converted csc matrix ...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17532: [SPARK-20214][ML] Make sure converted csc matrix ...

2017-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17532#discussion_r110057924 --- Diff: python/pyspark/mllib/tests.py --- @@ -853,6 +853,17 @@ def serialize(l): self.assertEqual(sv, serialize(lil.tocsr())) s

[GitHub] spark pull request #17532: [SPARK-20214][ML] Make sure converted csc matrix ...

2017-04-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17532#discussion_r110053944 --- Diff: python/pyspark/mllib/tests.py --- @@ -853,6 +853,17 @@ def serialize(l): self.assertEqual(sv, serialize(lil.tocsr())) self

[GitHub] spark pull request #17532: [SPARK-20214][ML] Make sure converted csc matrix ...

2017-04-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17532#discussion_r110052585 --- Diff: python/pyspark/ml/linalg/__init__.py --- @@ -72,7 +72,9 @@ def _convert_to_vector(l): return DenseVector(l) elif _have_scipy a

[GitHub] spark pull request #17532: [SPARK-20214][ML] Make sure converted csc matrix ...

2017-04-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17532#discussion_r109975956 --- Diff: python/pyspark/ml/linalg/__init__.py --- @@ -72,7 +72,9 @@ def _convert_to_vector(l): return DenseVector(l) elif _have_scip

[GitHub] spark pull request #17532: [SPARK-20214][ML] Make sure converted csc matrix ...

2017-04-04 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/17532 [SPARK-20214][ML] Make sure converted csc matrix has sorted indices ## What changes were proposed in this pull request? `_convert_to_vector` converts a scipy sparse matrix to csc matrix for