[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109972816 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -752,7 +752,7 @@ object SQLConf {

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109972663 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -51,6 +52,8 @@ class ConfigEntrySuite extends SparkFunSuite

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109972627 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -17,6 +17,7 @@ package

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109972286 --- Diff: core/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala --- @@ -147,6 +147,14 @@ private[spark] class TypedConfigBuilder[T](

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109958292 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -51,6 +52,26 @@ class ConfigEntrySuite extends

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109889257 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -51,6 +52,26 @@ class ConfigEntrySuite extends SparkFunSuite

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109889148 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -51,6 +52,26 @@ class ConfigEntrySuite extends SparkFunSuite

[GitHub] spark pull request #17537: [SPARK-20204][SQL][Followup] SQLConf should react...

2017-04-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17537#discussion_r109888449 --- Diff: core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala --- @@ -51,6 +52,26 @@ class ConfigEntrySuite extends SparkFunSuite