[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125651028 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1132,6 +1132,15 @@ private[spark] class

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125633693 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1132,6 +1132,15 @@ private[spark] class

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125575412 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,26 +46,47 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125567453 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,26 +46,47 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125567012 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,26 +46,47 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125564468 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,26 +46,47 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125563990 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala --- @@ -1316,8 +1316,10 @@ abstract class

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125563099 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,26 +46,47 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125563038 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala --- @@ -1316,8 +1316,10 @@ abstract class

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125562694 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,13 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-03 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125253313 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,14 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-03 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125250502 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1056,6 +1056,27 @@ class SessionCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125219807 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1056,6 +1056,27 @@ class SessionCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-07-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125219558 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,14 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-28 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124490206 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,14 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-27 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124442925 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,10 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124440921 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,10 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-27 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124435476 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,10 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-27 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124429467 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/events.scala --- @@ -140,6 +140,16 @@ case class

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124394208 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,10 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124393008 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/events.scala --- @@ -140,6 +140,16 @@ case class

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-26 Thread ouyangxiaochen
Github user ouyangxiaochen commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124183913 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,27 +46,53 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124181223 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,27 +46,53 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r124179677 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1458,6 +1458,8 @@ abstract class DDLSuite extends

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r122039641 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,27 +46,53 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r122039627 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,27 +46,53 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r122039659 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,27 +46,53 @@ case class CreateFunctionCommand(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r122038802 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1021,14 +1021,14 @@ class SessionCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r122038663 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -985,14 +985,14 @@ class SessionCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r122038583 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -985,14 +985,14 @@ class SessionCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r122038261 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala --- @@ -590,6 +590,14 @@ class InMemoryCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-04 Thread ouyangxiaochen
GitHub user ouyangxiaochen reopened a pull request: https://github.com/apache/spark/pull/17681 [SPARK-20383][SQL] Supporting Create [temporary] Function with the keyword 'IF NOT EXISTS' ## What changes were proposed in this pull request? support to create [temporary]

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-06-04 Thread ouyangxiaochen
Github user ouyangxiaochen closed the pull request at: https://github.com/apache/spark/pull/17681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-04-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r112272487 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -985,14 +985,14 @@ class SessionCatalog(

[GitHub] spark pull request #17681: [SPARK-20383][SQL] Supporting Create [temporary] ...

2017-04-19 Thread ouyangxiaochen
GitHub user ouyangxiaochen opened a pull request: https://github.com/apache/spark/pull/17681 [SPARK-20383][SQL] Supporting Create [temporary] Function with the keyword 'IF NOT EXISTS' ## What changes were proposed in this pull request? support to create [temporary]