Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17713
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r123682282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -139,32 +139,44 @@ case class In(value: Expressi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r123681616
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -139,32 +139,44 @@ case class In(value: Expressi
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115665978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +350,272 @@ trait CheckAnalysis extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115664356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +350,272 @@ trait CheckAnalysis extends P
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115154716
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -137,32 +137,46 @@ case class In(value: Express
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115154718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -386,16 +386,12 @@ trait CheckAnalysis extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115154225
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -386,16 +386,12 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115154162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -137,32 +137,46 @@ case class In(value: Expressi
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136422
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1462,7 +1253,7 @@ class Analyzer(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136437
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136427
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -142,27 +142,37 @@ case class In(value: Express
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136429
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1196,206 +1195,6 @@ class Analyzer(
}
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136424
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -142,27 +142,37 @@ case class In(value: Express
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115115028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1196,206 +1195,6 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114874
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -21,9 +21,13 @@ import org.apache.spark.sql.Anal
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114811
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114794
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114764
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1196,206 +1195,6 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114174
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1427,15 +1225,8 @@ class Analyzer(
// Ste
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114151
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -142,27 +142,37 @@ case class In(value: Expressi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115114133
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -142,27 +142,37 @@ case class In(value: Expressi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115113986
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1462,7 +1253,7 @@ class Analyzer(
c
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112819365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112805110
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/subq-input-typecheck.sql
---
@@ -0,0 +1,47 @@
+-- The test file cont
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112804747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112804589
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/subq-input-typecheck.sql
---
@@ -0,0 +1,47 @@
+-- The test file conta
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112804573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends P
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17713
[SPARK-20417][SQL] Move subquery error handling to checkAnalysis from
Analyzer
## What changes were proposed in this pull request?
Currently we do a lot of validations for subquery in the A
43 matches
Mail list logo
