[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113873456 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113855222 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113854501 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113851957 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113851718 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113847972 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113847076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -92,48 +93,8 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17785#discussion_r113846935 --- Diff: R/pkg/R/utils.R --- @@ -864,6 +864,14 @@ captureJVMException <- function(e, method) { # Extract the first message of JVM exception.

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/17785 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
GitHub user HyukjinKwon reopened a pull request: https://github.com/apache/spark/pull/17785 [SPARK-20493][R] De-deuplicate parse logics for DDL-like type strings in R ## What changes were proposed in this pull request? It seems we are using `SQLUtils.getSQLDataType` for

[GitHub] spark pull request #17785: [SPARK-20493][R] De-deuplicate parse logics for D...

2017-04-27 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/17785 [SPARK-20493][R] De-deuplicate parse logics for DDL-like type strings in R ## What changes were proposed in this pull request? It seems we are using `SQLUtils.getSQLDataType` for type