[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-05-06 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r115114733 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,143 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-05-05 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r115112172 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,143 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-05-04 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114893509 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,143 @@ object ALS extends DefaultParamsReadable[ALS] with Lo

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-05-02 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114283898 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -791,32 +813,43 @@ object ALS extends DefaultParamsReadable[ALS] with Log

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-29 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114065812 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-29 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114061940 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with Lo

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114044512 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114039105 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -1026,7 +1161,24 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038722 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038705 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038426 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114038185 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -791,32 +813,43 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114009389 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with Lo

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114003560 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with Lo

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114009897 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -1026,7 +1161,24 @@ object ALS extends DefaultParamsReadable[ALS] with Lo

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r114009801 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -910,26 +944,127 @@ object ALS extends DefaultParamsReadable[ALS] with Lo

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread danielyli
Github user danielyli commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r113894646 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -791,32 +813,43 @@ object ALS extends DefaultParamsReadable[ALS] with

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r113874652 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -791,32 +813,43 @@ object ALS extends DefaultParamsReadable[ALS] with Log

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17793#discussion_r113874567 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -791,32 +813,43 @@ object ALS extends DefaultParamsReadable[ALS] with Log

[GitHub] spark pull request #17793: [SPARK-20484][MLLIB] Add documentation to ALS cod...

2017-04-27 Thread danielyli
GitHub user danielyli opened a pull request: https://github.com/apache/spark/pull/17793 [SPARK-20484][MLLIB] Add documentation to ALS code ## What changes were proposed in this pull request? This PR adds documentation to the ALS code. ## How was this patch tested?