[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114724979 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114714285 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114709260 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114708724 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114708664 --- Diff: R/pkg/R/generics.R --- @@ -572,6 +572,10 @@ setGeneric("first", function(x, ...) { standardGeneric("first") }) #' @export

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114708146 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114704425 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114702184 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114698221 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114698264 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114698385 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114698072 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114698515 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2147,6 +2147,18 @@ test_that("join(), crossJoin() and merge() on a DataFrame", {

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114698548 --- Diff: R/pkg/R/generics.R --- @@ -572,6 +572,10 @@ setGeneric("first", function(x, ...) { standardGeneric("first") }) #' @export

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17851#discussion_r114698295 --- Diff: R/pkg/R/DataFrame.R --- @@ -3715,3 +3715,34 @@ setMethod("rollup", sgd <- callJMethod(x@sdf, "rollup", jcol)

[GitHub] spark pull request #17851: [SPARK-20585][SPARKR] R generic hint support

GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17851 [SPARK-20585][SPARKR] R generic hint support ## What changes were proposed in this pull request? Adds support for generic hints on `SparkDataFrame` ## How was this patch tested?