[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146169405 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col, lit}

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146168734 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146168660 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col, lit}

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146167919 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146167706 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col,

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146166006 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146165706 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r146165449 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col, lit}

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r145371903 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r145369694 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") (

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r145371704 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala --- @@ -42,7 +44,26 @@ import org.apache.spark.sql.functions.{col,

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r124576026 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala --- @@ -272,36 +272,16 @@ class LinearSVCSuite extends SparkFunSuite

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r124458920 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala --- @@ -272,36 +272,16 @@ class LinearSVCSuite extends

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r122607418 --- Diff: R/pkg/R/mllib_classification.R --- @@ -96,7 +98,8 @@ setClass("NaiveBayesModel", representation(jobj = "jobj")) #' @note spark.svmLinear

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r122607429 --- Diff: R/pkg/R/mllib_classification.R --- @@ -96,7 +98,8 @@ setClass("NaiveBayesModel", representation(jobj = "jobj")) #' @note spark.svmLinear

[GitHub] spark pull request #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squa...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17862#discussion_r122607391 --- Diff: R/pkg/R/mllib_classification.R --- @@ -96,7 +98,8 @@ setClass("NaiveBayesModel", representation(jobj = "jobj")) #' @note spark.svmLinear