[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115162164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf .c

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115162152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf .c

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115162139 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala --- @@ -68,6 +68,11 @@ object ParserUtils { /** Convert

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115156337 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115155941 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala --- @@ -68,6 +68,11 @@ object ParserUtils { /** Conv

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17887#discussion_r115155773 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -196,6 +196,14 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #17887: [SPARK-20399][SQL][WIP] Add a config to fallback ...

2017-05-06 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/17887 [SPARK-20399][SQL][WIP] Add a config to fallback string literal parsing consistent with old sql parser behavior ## What changes were proposed in this pull request? Follow the discussion in