[GitHub] spark pull request #18091: [SPARK-20868][CORE] UnsafeShuffleWriter should ve...

2017-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18091 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18091: [SPARK-20868][CORE] UnsafeShuffleWriter should ve...

2017-05-24 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/18091#discussion_r118360110 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java --- @@ -425,14 +425,8 @@ void forceSorterToSpill() throws IOException

[GitHub] spark pull request #18091: [SPARK-20868][CORE] UnsafeShuffleWriter should ve...

2017-05-24 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/18091#discussion_r118357370 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -376,6 +356,31 @@ private[spark] object Utils extends Logging { } }

[GitHub] spark pull request #18091: [SPARK-20868][CORE] UnsafeShuffleWriter should ve...

2017-05-24 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/18091#discussion_r118353244 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java --- @@ -425,14 +425,8 @@ void forceSorterToSpill() throws IOException

[GitHub] spark pull request #18091: [SPARK-20868][CORE] UnsafeShuffleWriter should ve...

2017-05-24 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/18091 [SPARK-20868][CORE] UnsafeShuffleWriter should verify the position after FileChannel.transferTo ## What changes were proposed in this pull request? Long time ago we fixed a