Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123050801
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala ---
@@ -150,11 +154,11 @@ class GBTRegressor @Since("1.4.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123049135
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -136,6 +136,10 @@ class GBTClassifier @Since("1.4.0") (
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123051195
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -118,11 +119,12 @@ class DecisionTreeRegressor
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123040612
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -73,19 +75,21 @@ private[spark] object GradientBoostedTrees
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123039522
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala ---
@@ -140,6 +140,10 @@ class GBTRegressor @Since("1.4.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123049728
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -192,6 +196,9 @@ object GBTClassifier extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123040767
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -284,11 +290,13 @@ private[spark] object
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123051005
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -319,8 +327,10 @@ private[spark] object GradientBoostedTrees
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123050956
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -284,11 +290,13 @@ private[spark] object
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r123042480
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -49,14 +49,16 @@ import org.apache.spark.rdd.RDD
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119365434
--- Diff: project/MimaExcludes.scala ---
@@ -37,11 +37,15 @@ object MimaExcludes {
// Exclude rules for 2.3.x
lazy val v23excludes =
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364985
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -420,18 +394,18 @@ private[ml] trait RandomForestParams extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119365001
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -441,12 +415,44 @@ private[ml] trait RandomForestParams extends
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364950
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -305,7 +305,7 @@ private[ml] object TreeRegressorParams {
}
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364792
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -136,12 +136,20 @@ class GBTClassifier @Since("1.4.0") (
Github user pralabhkumar commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119364846
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -99,6 +99,8 @@ class DecisionTreeRegressor
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119271935
--- Diff: project/MimaExcludes.scala ---
@@ -37,11 +37,15 @@ object MimaExcludes {
// Exclude rules for 2.3.x
lazy val v23excludes = v22excludes
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119271662
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -441,12 +415,44 @@ private[ml] trait RandomForestParams extends
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119271607
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -420,18 +394,18 @@ private[ml] trait RandomForestParams extends
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119271552
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
@@ -305,7 +305,7 @@ private[ml] object TreeRegressorParams {
}
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119271063
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -99,6 +99,8 @@ class DecisionTreeRegressor @Since("1.4.0")
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/18118#discussion_r119270999
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -136,12 +136,20 @@ class GBTClassifier @Since("1.4.0") (
GitHub user pralabhkumar opened a pull request:
https://github.com/apache/spark/pull/18118
SPARK-20199 : Provided featureSubsetStrategy to GBTClassifier
## What changes were proposed in this pull request?
(Provided featureSubset Strategy to GBTClassifier
a) Moved
23 matches
Mail list logo
