[GitHub] spark pull request #18240: [SPARK-21017][sql]Move the length getter before t...

2017-06-08 Thread eatoncys
Github user eatoncys closed the pull request at: https://github.com/apache/spark/pull/18240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18240: [SPARK-21017][sql]Move the length getter before t...

2017-06-08 Thread eatoncys
Github user eatoncys commented on a diff in the pull request: https://github.com/apache/spark/pull/18240#discussion_r120840468 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveFileFormat.scala --- @@ -142,7 +142,8 @@ class HiveOutputWriter(

[GitHub] spark pull request #18240: [SPARK-21017][sql]Move the length getter before t...

2017-06-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18240#discussion_r120837951 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveFileFormat.scala --- @@ -142,7 +142,8 @@ class HiveOutputWriter(

[GitHub] spark pull request #18240: [SPARK-21017][sql]Move the length getter before t...

2017-06-08 Thread eatoncys
GitHub user eatoncys opened a pull request: https://github.com/apache/spark/pull/18240 [SPARK-21017][sql]Move the length getter before the while to improve performance ## What changes were proposed in this pull request? In my test, the cost of the while in the write