Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18265#discussion_r121315755
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -188,6 +188,15 @@ class Word2VecSuite extends SparkFunSuite with
ML
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18265#discussion_r121315677
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -188,6 +188,15 @@ class Word2VecSuite extends SparkFunSuite with
ML
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18265#discussion_r121315648
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -355,9 +364,12 @@ object Word2VecModel extends MLReadable[Word2VecModel]
Github user Krimit commented on a diff in the pull request:
https://github.com/apache/spark/pull/18265#discussion_r121277008
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -188,6 +188,15 @@ class Word2VecSuite extends SparkFunSuite with
MLlib
Github user Krimit commented on a diff in the pull request:
https://github.com/apache/spark/pull/18265#discussion_r121277000
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -188,6 +188,15 @@ class Word2VecSuite extends SparkFunSuite with
MLlib
Github user Krimit commented on a diff in the pull request:
https://github.com/apache/spark/pull/18265#discussion_r121276885
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -355,9 +364,12 @@ object Word2VecModel extends MLReadable[Word2VecModel]
{
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/18265
[SPARK-21050][ML] Word2vec persistence overflow bug fix
## What changes were proposed in this pull request?
The method calculateNumberOfPartitions() uses Int, not Long (unlike the
MLlib
