Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121735491
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,40 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121736014
--- Diff: python/pyspark/ml/classification.py ---
@@ -1510,21 +1511,26 @@ class OneVsRest(Estimator, OneVsRestParams,
MLReadable, MLWritable):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121740343
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -325,8 +343,13 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121733736
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -65,6 +67,12 @@ private[ml] trait OneVsRestParams extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121734558
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -283,6 +295,12 @@ final class OneVsRest @Since("1.4.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121737179
--- Diff: python/pyspark/ml/classification.py ---
@@ -1560,14 +1566,27 @@ def trainSingleClass(index):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121736656
--- Diff: python/pyspark/ml/classification.py ---
@@ -1560,14 +1566,27 @@ def trainSingleClass(index):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121735870
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,40 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121735342
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,40 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121735271
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -101,6 +101,40 @@ class OneVsRestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121737455
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,7 +1229,35 @@ def test_output_columns(self):
(2.0,
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121734092
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -65,6 +67,12 @@ private[ml] trait OneVsRestParams extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r121737343
--- Diff: python/pyspark/ml/tests.py ---
@@ -1229,7 +1229,35 @@ def test_output_columns(self):
(2.0,
13 matches
Mail list logo
