[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-09-10 Thread mmolimar
Github user mmolimar closed the pull request at: https://github.com/apache/spark/pull/18447 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r212820817 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -98,6 +98,29 @@ case class AssertTrue(child:

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r212820670 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -98,6 +98,29 @@ case class AssertTrue(child:

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r212820641 --- Diff: R/pkg/R/generics.R --- @@ -950,6 +949,10 @@ setGeneric("grouping_bit", function(x) { standardGeneric("grouping_bit") }) #' @name NULL

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-05-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r186278707 --- Diff: R/pkg/R/functions.R --- @@ -679,6 +679,19 @@ setMethod("hash", column(jc) }) +#' @details +#'

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-05-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r186278702 --- Diff: R/pkg/R/functions.R --- @@ -679,6 +679,19 @@ setMethod("hash", column(jc) }) +#' @details +#'

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-05-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r186278685 --- Diff: R/pkg/R/functions.R --- @@ -679,6 +679,19 @@ setMethod("hash", column(jc) }) +#' @details +#'

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r186252381 --- Diff: R/pkg/R/functions.R --- @@ -679,6 +679,19 @@ setMethod("hash", column(jc) }) +#' @details +#'

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r186252423 --- Diff: R/pkg/NAMESPACE --- @@ -236,6 +236,7 @@ exportMethods("%<=>%", "current_date", "current_timestamp",

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-05-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r186252398 --- Diff: R/pkg/R/functions.R --- @@ -679,6 +679,19 @@ setMethod("hash", column(jc) }) +#' @details +#'

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2018-05-03 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r185703059 --- Diff: R/pkg/R/functions.R --- @@ -653,6 +653,25 @@ setMethod("hash", column(jc) }) +#' data_type +#'

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-07-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r130032578 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -209,6 +209,18 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-07-28 Thread mmolimar
Github user mmolimar commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r130025210 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -209,6 +209,18 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-07-11 Thread mmolimar
Github user mmolimar commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r126710311 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -209,6 +209,18 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-07-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r125195855 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -209,6 +209,18 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-06-28 Thread mmolimar
Github user mmolimar commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r124545289 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -209,6 +209,18 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-06-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r124473417 --- Diff: R/pkg/R/functions.R --- @@ -598,6 +598,25 @@ setMethod("hash", column(jc) }) +#' data_type +#'

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-06-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r124473373 --- Diff: python/pyspark/sql/functions.py --- @@ -1248,6 +1248,17 @@ def hash(*cols): return Column(jc) +def data_type(col):

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-06-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18447#discussion_r124470787 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -209,6 +209,18 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

2017-06-28 Thread mmolimar
GitHub user mmolimar opened a pull request: https://github.com/apache/spark/pull/18447 [SPARK-21232][SQL][SparkR][PYSPARK] New built-in SQL function - Data_Type ## What changes were proposed in this pull request? New built-in function to get the data type of columns in SQL.