[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126686970 --- Diff: python/pyspark/sql/functions.py --- @@ -2026,16 +2026,26 @@ def __init__(self, func, returnType, name=None): "{0}".format(

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126605703 --- Diff: python/pyspark/sql/types.py --- @@ -806,43 +786,43 @@ def _parse_datatype_string(s): >>> _parse_datatype_string("blabla") # doctest:

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126598613 --- Diff: python/pyspark/sql/functions.py --- @@ -2026,16 +2026,26 @@ def __init__(self, func, returnType, name=None): "{0}".format(type

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126597140 --- Diff: python/pyspark/sql/types.py --- @@ -806,43 +786,43 @@ def _parse_datatype_string(s): >>> _parse_datatype_string("blabla") # doctest: +I

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126482669 --- Diff: python/pyspark/sql/tests.py --- @@ -1246,6 +1246,31 @@ def test_struct_type(self): with self.assertRaises(TypeError):

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18590#discussion_r126481623 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala --- @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Softw

[GitHub] spark pull request #18590: [SPARK-21365][PYTHON] Deduplicate logics parsing ...

2017-07-10 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/18590 [SPARK-21365][PYTHON] Deduplicate logics parsing DDL type/schema definition ## What changes were proposed in this pull request? This PR deals with three points as below: - Reus