[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-12 Thread liu-zhaokun
Github user liu-zhaokun closed the pull request at: https://github.com/apache/spark/pull/18596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18596#discussion_r126724142 --- Diff: dev/make-distribution.sh --- @@ -163,7 +163,7 @@ echo -e "\$ ${BUILD_COMMAND[@]}\n" rm -rf "$DISTDIR" mkdir -p "$DISTDIR/jars" echo

[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-11 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18596#discussion_r126691780 --- Diff: dev/make-distribution.sh --- @@ -163,7 +163,7 @@ echo -e "\$ ${BUILD_COMMAND[@]}\n" rm -rf "$DISTDIR" mkdir -p "$DISTDIR/jars"

[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-11 Thread liu-zhaokun
Github user liu-zhaokun commented on a diff in the pull request: https://github.com/apache/spark/pull/18596#discussion_r126669564 --- Diff: dev/make-distribution.sh --- @@ -163,7 +163,7 @@ echo -e "\$ ${BUILD_COMMAND[@]}\n" rm -rf "$DISTDIR" mkdir -p "$DISTDIR/jars"

[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-11 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18596#discussion_r126636441 --- Diff: dev/make-distribution.sh --- @@ -163,7 +163,7 @@ echo -e "\$ ${BUILD_COMMAND[@]}\n" rm -rf "$DISTDIR" mkdir -p "$DISTDIR/jars"

[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18596#discussion_r126623139 --- Diff: dev/make-distribution.sh --- @@ -163,7 +163,7 @@ echo -e "\$ ${BUILD_COMMAND[@]}\n" rm -rf "$DISTDIR" mkdir -p "$DISTDIR/jars" echo

[GitHub] spark pull request #18596: [SPARK-21371] dev/make-distribution.sh scripts us...

2017-07-10 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/spark/pull/18596 [SPARK-21371] dev/make-distribution.sh scripts use of $@ without "" [https://issues.apache.org/jira/browse/SPARK-21371](https://issues.apache.org/jira/browse/SPARK-21371)