[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-20 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18684#discussion_r128575547 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -188,17 +189,20 @@ public void

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-20 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18684#discussion_r128572437 --- Diff: common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java --- @@ -132,7 +134,8 @@ public Object

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-20 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18684#discussion_r128448743 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -188,17 +189,20 @@ public void

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-20 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18684#discussion_r128449639 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -188,17 +189,20 @@ public void

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-20 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18684#discussion_r128447912 --- Diff: common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java --- @@ -132,7 +134,8 @@ public Object

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18684#discussion_r128334963 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -188,17 +189,20 @@ public void

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18684#discussion_r128334779 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -188,17 +189,20 @@ public void

[GitHub] spark pull request #18684: [SPARK-21475][Core] Use NIO's Files API to replac...

2017-07-19 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/18684 [SPARK-21475][Core] Use NIO's Files API to replace FileInputStream/FileOutputStream in some critical paths ## What changes were proposed in this pull request? Java's `FileInputStream`