[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2018-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18697 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2017-08-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18697#discussion_r136378843 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -171,6 +171,16 @@ sealed trait Partitioning

[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2017-07-31 Thread aray
Github user aray commented on a diff in the pull request: https://github.com/apache/spark/pull/18697#discussion_r130396904 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -65,6 +65,10 @@ abstract class SparkPlan extends QueryPlan[SparkPlan]

[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2017-07-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18697#discussion_r130286295 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -36,6 +40,70 @@ class JoinSuite extends QueryTest with SharedSQLContext {

[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2017-07-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18697#discussion_r130286222 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -36,6 +40,70 @@ class JoinSuite extends QueryTest with SharedSQLContext {

[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2017-07-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18697#discussion_r130286066 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -65,6 +65,10 @@ abstract class SparkPlan extends QueryPlan[SparkPlan]

[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2017-07-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18697#discussion_r130278378 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -80,7 +80,7 @@ case class ProjectExec(projectList: Seq[

[GitHub] spark pull request #18697: [SPARK-16683][SQL] Repeated joins to same table c...

2017-07-20 Thread aray
GitHub user aray opened a pull request: https://github.com/apache/spark/pull/18697 [SPARK-16683][SQL] Repeated joins to same table can leak attributes via partitioning ## What changes were proposed in this pull request? In some complex queries where the same table is joined