[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...

2018-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18903 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...

2017-08-12 Thread KevinZwx
Github user KevinZwx commented on a diff in the pull request: https://github.com/apache/spark/pull/18903#discussion_r132821343 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala --- @@ -77,6 +77,19 @@ class TimeWindowSuite

[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...

2017-08-11 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/18903#discussion_r132729005 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala --- @@ -77,6 +77,19 @@ class TimeWindowSuite extends

[GitHub] spark pull request #18903: [SPARK-21590][SS]Window start time should support...

2017-08-10 Thread KevinZwx
GitHub user KevinZwx opened a pull request: https://github.com/apache/spark/pull/18903 [SPARK-21590][SS]Window start time should support negative values ## What changes were proposed in this pull request? Remove the non-negative checks of window start time to make window