[GitHub] spark pull request #18959: [SPARK-18394][SQL] Make an Attribute.toSeq output...

2017-08-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18959#discussion_r133446082 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala --- @@ -121,7 +121,12 @@ class AttributeSet private (val

[GitHub] spark pull request #18959: [SPARK-18394][SQL] Make an Attribute.toSeq output...

2017-08-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/18959#discussion_r133445750 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala --- @@ -121,7 +121,12 @@ class AttributeSet private

[GitHub] spark pull request #18959: [SPARK-18394][SQL] Make an Attribute.toSeq output...

2017-08-16 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18959#discussion_r133383172 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala --- @@ -121,7 +121,12 @@ class AttributeSet private (val

[GitHub] spark pull request #18959: [SPARK-18394][SQL] Make an Attribute.toSeq output...

2017-08-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18959#discussion_r133379380 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala --- @@ -121,7 +121,12 @@ class AttributeSet private (val

[GitHub] spark pull request #18959: [SPARK-18394][SQL] Make an Attribute.toSeq output...

2017-08-16 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/18959 [SPARK-18394][SQL] Make an Attribute.toSeq output order consistent ## What changes were proposed in this pull request? This pr sorted output attributes on their name and exprId in