[GitHub] spark pull request #19249: [SPARK-22032] Speed up StructType.fromInternal

2017-09-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19249#discussion_r139301428 --- Diff: python/pyspark/sql/types.py --- @@ -619,7 +621,8 @@ def fromInternal(self, obj): # it's already converted by pickler

[GitHub] spark pull request #19249: [SPARK-22032] Speed up StructType.fromInternal

2017-09-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19249#discussion_r139286221 --- Diff: python/pyspark/sql/types.py --- @@ -619,7 +621,8 @@ def fromInternal(self, obj): # it's already converted by pickler

[GitHub] spark pull request #19249: [SPARK-22032] Speed up StructType.fromInternal

2017-09-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19249#discussion_r139286195 --- Diff: python/pyspark/sql/types.py --- @@ -619,7 +621,8 @@ def fromInternal(self, obj): # it's already converted by pickler

[GitHub] spark pull request #19249: [SPARK-22032] Speed up StructType.fromInternal

2017-09-15 Thread maver1ck
GitHub user maver1ck opened a pull request: https://github.com/apache/spark/pull/19249 [SPARK-22032] Speed up StructType.fromInternal ## What changes were proposed in this pull request? StructType.fromInternal is calling f.fromInternal(v) for every field. We can use need