[GitHub] spark pull request #19254: [MINOR][CORE] Cleanup dead code and duplication i...

2017-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19254 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19254: [MINOR][CORE] Cleanup dead code and duplication i...

2017-09-17 Thread original-brownbear
Github user original-brownbear commented on a diff in the pull request: https://github.com/apache/spark/pull/19254#discussion_r139307959 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -403,6 +391,16 @@ public long spill(long numBytes) throws IO

[GitHub] spark pull request #19254: [MINOR][CORE] Cleanup dead code and duplication i...

2017-09-17 Thread original-brownbear
Github user original-brownbear commented on a diff in the pull request: https://github.com/apache/spark/pull/19254#discussion_r139305653 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -403,6 +391,16 @@ public long spill(long numBytes) throws IO

[GitHub] spark pull request #19254: [MINOR][CORE] Cleanup dead code and duplication i...

2017-09-17 Thread original-brownbear
Github user original-brownbear commented on a diff in the pull request: https://github.com/apache/spark/pull/19254#discussion_r139305647 --- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java --- @@ -116,13 +110,7 @@ public void freeArray(LongArray array) {

[GitHub] spark pull request #19254: [MINOR][CORE] Cleanup dead code and duplication i...

2017-09-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19254#discussion_r139304891 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -403,6 +391,16 @@ public long spill(long numBytes) throws IOException {

[GitHub] spark pull request #19254: [MINOR][CORE] Cleanup dead code and duplication i...

2017-09-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19254#discussion_r139304877 --- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java --- @@ -116,13 +110,7 @@ public void freeArray(LongArray array) { protected Me

[GitHub] spark pull request #19254: [MINOR][CORE] Cleanup dead code and duplication i...

2017-09-16 Thread original-brownbear
GitHub user original-brownbear opened a pull request: https://github.com/apache/spark/pull/19254 [MINOR][CORE] Cleanup dead code and duplication in Mem. Management ## What changes were proposed in this pull request? * Removed the method `org.apache.spark.sql.catalyst.expres