Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146772862
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3249,9 +3249,12 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146760035
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3249,9 +3249,12 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146757169
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3249,9 +3249,12 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146757193
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3249,9 +3249,12 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146757250
--- Diff: R/run-tests.sh ---
@@ -38,6 +38,7 @@ FAILED=$((PIPESTATUS[0]||$FAILED))
NUM_CRAN_WARNING="$(grep -c WARNING$ $CRAN_CHECK_LOG_FILE)"
N