[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19570 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147544853 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147544758 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147544733 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147540587 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147540274 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147464434 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147119002 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147118974 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147117969 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147117297 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-24 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/19570 [SPARK-22335][SQL] Clarify union behavior on Dataset of typed objects in the document ## What changes were proposed in this pull request? Seems that end users can be confused by the