[GitHub] spark pull request #19577: [SPARK-22355][SQL] Dataset.collect is not threads...

2017-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19577 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19577: [SPARK-22355][SQL] Dataset.collect is not threads...

2017-10-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19577#discussion_r147194202 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2661,7 +2657,12 @@ class Dataset[T] private[sql]( */ def

[GitHub] spark pull request #19577: [SPARK-22355][SQL] Dataset.collect is not threads...

2017-10-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19577#discussion_r147037025 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3102,7 +3103,12 @@ class Dataset[T] private[sql]( * Collect all elements

[GitHub] spark pull request #19577: [SPARK-22355][SQL] Dataset.collect is not threads...

2017-10-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19577#discussion_r147035745 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3102,7 +3103,12 @@ class Dataset[T] private[sql]( * Collect all

[GitHub] spark pull request #19577: [SPARK-22355][SQL] Dataset.collect is not threads...

2017-10-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19577#discussion_r147032429 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2661,7 +2657,12 @@ class Dataset[T] private[sql]( */ def

[GitHub] spark pull request #19577: [SPARK-22355][SQL] Dataset.collect is not threads...

2017-10-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19577#discussion_r147032280 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3102,7 +3103,12 @@ class Dataset[T] private[sql]( * Collect all elements

[GitHub] spark pull request #19577: [SPARK-22355][SQL] Dataset.collect is not threads...

2017-10-25 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19577 [SPARK-22355][SQL] Dataset.collect is not threadsafe ## What changes were proposed in this pull request? It's possible that users create a `Dataset`, and call `collect` of this