[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168364882 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -51,33 +52,16 @@ import

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168364718 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168364491 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168364257 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -784,6 +794,9 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168363855 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168363726 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168363672 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -656,7 +664,9 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-14 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r168363561 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -69,6 +70,10 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165518653 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165516803 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -51,33 +52,16 @@ import org.apache.spark.util._

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165516090 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -784,6 +794,9 @@ private[spark] class Client( val

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165516542 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165515886 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -656,7 +664,9 @@ private[spark] class Client( //

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165518845 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165515603 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -69,6 +70,10 @@ private[spark] class Client(

[GitHub] spark pull request #19616: [SPARK-22404][YARN] Provide an option to use unma...

2018-02-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19616#discussion_r165516482 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1104,14 +1117,39 @@ private[spark] class Client(