[GitHub] spark pull request #19672: [SPARK-22456] Add support for dayofweek function

2017-11-07 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19672#discussion_r149302867 --- Diff: python/pyspark/sql/functions.py --- @@ -869,6 +869,19 @@ def month(col): return Column(sc._jvm.functions.month(_to_java_column(col)))

[GitHub] spark pull request #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19672#discussion_r149275610 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2550,6 +2550,13 @@ object functions { * @group datetime_funcs *

[GitHub] spark pull request #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19672#discussion_r149256287 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2550,6 +2550,13 @@ object functions { * @group datetime_funcs

[GitHub] spark pull request #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19672#discussion_r149122409 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2550,6 +2550,13 @@ object functions { * @group datetime_funcs

[GitHub] spark pull request #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19672#discussion_r149124210 --- Diff: python/pyspark/sql/functions.py --- @@ -869,6 +869,19 @@ def month(col): return Column(sc._jvm.functions.month(_to_java_column(col)))

[GitHub] spark pull request #19672: [SPARK-22456] Add support for dayofweek function

2017-11-06 Thread ptkool
GitHub user ptkool opened a pull request: https://github.com/apache/spark/pull/19672 [SPARK-22456] Add support for dayofweek function ## What changes were proposed in this pull request? This PR adds support for a new function called `dayofweek` that returns the day of the week o