Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19792
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156971910
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,11 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156941615
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,11 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156340749
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156339240
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156338937
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156337091
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r15602
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r156279744
--- Diff: python/pyspark/sql/types.py ---
@@ -1083,7 +1083,8 @@ def _infer_schema(row):
elif hasattr(row, "_fields"): # namedtuple
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r155424467
--- Diff: python/pyspark/sql/session.py ---
@@ -405,14 +401,9 @@ def _createFromLocal(self, data, schema):
data = list(data)
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r155238727
--- Diff: python/pyspark/sql/session.py ---
@@ -405,7 +401,7 @@ def _createFromLocal(self, data, schema):
data = list(data)
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r155238617
--- Diff: python/pyspark/sql/session.py ---
@@ -405,7 +401,7 @@ def _createFromLocal(self, data, schema):
data = list(data)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r155224258
--- Diff: python/pyspark/sql/session.py ---
@@ -405,7 +401,7 @@ def _createFromLocal(self, data, schema):
data = list(data)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r154820118
--- Diff: python/pyspark/sql/session.py ---
@@ -324,11 +324,12 @@ def range(self, start, end=None, step=1,
numPartitions=None):
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r154630463
--- Diff: python/pyspark/sql/session.py ---
@@ -337,7 +338,7 @@ def _inferSchemaFromList(self, data):
if type(first) is dict:
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r154036405
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,33 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153972800
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,33 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153692220
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153579071
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153578612
--- Diff: python/pyspark/sql/tests.py ---
@@ -1722,6 +1723,83 @@ def test_infer_long_type(self):
self.assertEqual(_infer_type(2**61),
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153394082
--- Diff: python/pyspark/sql/tests.py ---
@@ -1722,6 +1723,83 @@ def test_infer_long_type(self):
self.assertEqual(_infer_type(2**61),
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153160307
--- Diff: python/pyspark/sql/tests.py ---
@@ -1722,6 +1723,83 @@ def test_infer_long_type(self):
self.assertEqual(_infer_type(2**61),
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153138373
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153137292
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153132348
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153130823
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153130303
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r15398
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r153110594
--- Diff: python/pyspark/sql/tests.py ---
@@ -1722,6 +1723,83 @@ def test_infer_long_type(self):
self.assertEqual(_infer_type(2**61),
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r152478594
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,22 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
Github user ebuildy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r152397263
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,22 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def
GitHub user gberger opened a pull request:
https://github.com/apache/spark/pull/19792
[SPARK-22566][PYTHON] Better error message for `_merge_type` in Pandas to
Spark DF conversion
## What changes were proposed in this pull request?
It provides a better error message when
32 matches
Mail list logo
