[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19815 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153082361 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(in

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153082266 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(in

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153082248 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(in

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153082230 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(in

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153080574 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -494,9 +495,8 @@ public void putArray(int rowI

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153080187 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java --- @@ -494,9 +495,8 @@ public void putArray(int rowI

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153080542 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(in

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-25 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153061379 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(int row

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153060413 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(int ro

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19815#discussion_r153060336 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -324,24 +315,27 @@ public void putDecimal(int ro

[GitHub] spark pull request #19815: [SPARK-22602][SQL] remove ColumnVector#loadBytes

2017-11-24 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19815 [SPARK-22602][SQL] remove ColumnVector#loadBytes ## What changes were proposed in this pull request? `ColumnVector#loadBytes` is only used as an optimization for reading UTF8String in `W