[GitHub] spark pull request #19835: [SPARK-21866][ML][PYTHON][FOLLOWUP] Few cleanups ...

2017-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19835 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19835: [SPARK-21866][ML][PYTHON][FOLLOWUP] Few cleanups ...

2017-11-28 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19835#discussion_r153689403 --- Diff: python/pyspark/ml/image.py --- @@ -146,7 +163,12 @@ def toImage(self, array, origin=""): mode = ocvTypes["CV_8UC4"]

[GitHub] spark pull request #19835: [SPARK-21866][ML][PYTHON][FOLLOWUP] Few cleanups ...

2017-11-28 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/19835#discussion_r153689356 --- Diff: python/pyspark/ml/tests.py --- @@ -1836,6 +1836,24 @@ def test_read_images(self): self.assertEqual(ImageSchema.imageFields,