Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19911
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155916550
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -147,14 +157,6 @@ abstract class JdbcDialect extends
Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155916248
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -147,14 +157,6 @@ abstract class JdbcDialect extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155884560
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala
---
@@ -66,9 +66,9 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155883944
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -147,14 +157,6 @@ abstract class JdbcDialect extends Serializable
Github user bolkedebruin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155624133
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {
Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155622687
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {
Github user bolkedebruin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155619800
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {
Github user bolkedebruin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155619721
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala ---
@@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155561087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -98,10 +98,11 @@ object JdbcUtils extends
Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155515480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala ---
@@ -85,6 +85,10 @@ private object PostgresDialect extends
Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/19911#discussion_r155515466
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -116,6 +116,17 @@ abstract class JdbcDialect extends
12 matches
Mail list logo
