Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19912
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155543551
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,94 @@ object ConstantFolding extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155542336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,94 @@ object ConstantFolding extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155415232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155414906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155413508
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155412840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155411680
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155340047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155322559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155332134
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155340566
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155340617
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19912#discussion_r155322305
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -64,50 +64,91 @@ object ConstantFolding extends
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/19912
[SPARK-22719][SQL]Refactor ConstantPropagation
## What changes were proposed in this pull request?
The current time complexity of ConstantPropagation is O(n^2), which can be
slow
15 matches
Mail list logo