[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19918 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19918#discussion_r156236383 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/binaryComparison.sql --- @@ -0,0 +1,287 @@ +-- +-- Licensed to the

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19918#discussion_r156087307 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/binaryComparison.sql --- @@ -0,0 +1,287 @@ +-- +-- Licensed to the

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19918#discussion_r156087093 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/binaryComparison.sql --- @@ -0,0 +1,287 @@ +-- +-- Licensed to the

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-09 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/19918#discussion_r155939348 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/binaryComparison.sql --- @@ -0,0 +1,287 @@ +-- +-- Licensed to the

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19918#discussion_r155452007 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -300,7 +300,7 @@ class SQLQueryTestSuite extends QueryTest with

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19918#discussion_r155451745 --- Diff: sql/core/src/test/resources/sql-tests/results/predicate-functions.sql.out --- @@ -1,5 +1,5 @@ -- Automatically generated by

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19918#discussion_r155451509 --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/binaryComparison.sql --- @@ -0,0 +1,287 @@ +-- +-- Licensed to the

[GitHub] spark pull request #19918: [SPARK-22726] [TEST] Basic tests for Binary Compa...

2017-12-07 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/19918 [SPARK-22726] [TEST] Basic tests for Binary Comparison and ImplicitTypeCasts ## What changes were proposed in this pull request? Before we deliver the Hive compatibility mode, we plan to