Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20136
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20136#discussion_r159416180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -70,7 +72,7 @@ object SQLConf {
* Default config. Only
Github user juliuszsompolski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20136#discussion_r159408791
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -70,7 +72,7 @@ object SQLConf {
* Default config.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20136#discussion_r159363498
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -70,7 +72,7 @@ object SQLConf {
* Default config. Only
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20136#discussion_r159252410
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1087,6 +1089,11 @@ object SQLConf {
class SQLConf extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20136#discussion_r159247039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -70,7 +72,12 @@ object SQLConf {
* Default config. Only
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20136#discussion_r159240318
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -70,7 +71,10 @@ object SQLConf {
* Default config. Only
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20136#discussion_r159239867
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -70,7 +71,10 @@ object SQLConf {
* Default config. Only
GitHub user juliuszsompolski opened a pull request:
https://github.com/apache/spark/pull/20136
[SPARK-22938] Assert that SQLConf.get is accessed only on the driver.
## What changes were proposed in this pull request?
Assert if code tries to access SQLConf.get on executor.
